add support for getParsedJSONAssignment method returning JsonNode (FF-896) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerank
approved these changes
Sep 13, 2023
aarsilv
approved these changes
Sep 13, 2023
| @@ -258,7 +260,7 @@ public Optional<Double> getDoubleAssignment(String subjectKey, String experiment | |||
| * @param subjectAttributes | |||
| * @return | |||
| */ | |||
| public Optional<String> getJSONAssignment(String subjectKey, String experimentKey, | |||
| public Optional<String> getJSONStringAssignment(String subjectKey, String experimentKey, | |||
| * @param subjectAttributes | ||
| * @return | ||
| */ | ||
| public Optional<JsonNode> getParsedJSONAssignment(String subjectKey, String experimentKey, |
Comment on lines
+166
to
+168
| assertEquals(testCase.expectedAssignments, actualJSONAssignments.stream() | ||
| .map(node -> node.toString()) | ||
| .collect(Collectors.toList())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
note to reviewers: the diff of
EppoClientTest.javais a little strange reviewing side by side please take care.testing
unit tests access json via the parsed method in order to exercise both the
JsonNodeandStringreturn types.